New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit @nowarn
annotations from generated code, for forwards compatibility at compile-time
#9491
Conversation
...by special-casing them. In principle we have `extends Annotation` vs `extends StaticAnnotation` for that, but sadly `ConstantAnnotation extends StaticAnnotation`, so we don't get to choose for those :-/
@nowarn
annotations...@nowarn
annotations from generated code, for forwards compatibility
@nowarn
annotations from generated code, for forwards compatibility@nowarn
annotations from generated code, for forwards compatibility at compile-time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I guess we don't have the testing infra to simulate compiling with a different/older stdlib.
@lrytz this should target 2.12.x, I think? won't 2.12.13 users be affected as well? |
Lukas in team meeting: "We should backport it" to 2.12 |
@lrytz I thought I'd take 1 minute to submit a backport but it isn't 1-minute job, the method you modified doesn't exist in 2.12. do you want to backport it, or shall I look into it next week? |
|
...by special-casing them.
In principle we have
extends Annotation
vsextends StaticAnnotation
for that, but sadly
ConstantAnnotation extends StaticAnnotation
, sowe don't get to choose for those :-/
Fixes scala/bug#12336
(Note that the bug only caused problems at compile time, not at runtime)